Good or bad? This is a highly private and sensitive subject for most people. Most couples do not even discuss this prior to their wedding and most divorces are caused by this very thing topic. When a couple gets married they are entering a business deal, like it or not, and finances are considered community property in most states. If one of the couple has bad credit or even high debt that becomes the others debt as well. If there is property owned by one that is a family property it now becomes both of theirs.
When a couple is willing to sit down and talk with one another about this topic it opens up a conversation that can and most of the time will bring the couple closer together and gets all secrets out in the open. You both will know where you are in the relationship. You can help each other out if there are problems and even set up goals as to where you want to be as a couple. If you have taken a premarital course or counselling this will have been discussed already. Yes, it is embarrassing and uncomfortable to discuss but, if you can't talk about it with your future spouse who are you going to talk to. So, yes, it is a good thing to get this out in the open.
I am not a millionaire so I don't need to worry with this. Everyone should be willing to have one. It is not always about money you will owe if you divorce or who gets the vacation home and the apartment in France, it is about what will happen to these things if something does happen. Keeps the days in and out of court to a minimum and makes it all nice and neat.
The couple should seek legal counsel before a marriage if they feel that there might be problems with money or property and each should have their own representative.
Uncomfortable or not open up and discuss with your loved one.
Blessings on all and have a wonderful week.